Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 718393005: Enable the profiler on the simulator (Closed)

Created:
6 years, 1 month ago by Cutch
Modified:
6 years ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Enable the profiler on the simulator R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41752

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -19 lines) Patch
M runtime/vm/isolate.cc View 1 2 3 chunks +8 lines, -10 lines 0 comments Download
M runtime/vm/profiler.cc View 3 chunks +17 lines, -9 lines 0 comments Download
M runtime/vm/simulator_arm.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm64.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M runtime/vm/simulator_mips.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 1 2 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
https://codereview.chromium.org/718393005/diff/20001/runtime/vm/assembler_arm64.h File runtime/vm/assembler_arm64.h (right): https://codereview.chromium.org/718393005/diff/20001/runtime/vm/assembler_arm64.h#newcode1720 runtime/vm/assembler_arm64.h:1720: int32_t opc = 0; Fixes Mac compilation error.
6 years, 1 month ago (2014-11-14 17:15:30 UTC) #2
siva
LGTM with one comment that we discussed offline regarding the potential possibility that ticks in ...
6 years, 1 month ago (2014-11-14 18:02:51 UTC) #3
Cutch
6 years, 1 month ago (2014-11-14 23:15:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 41752 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698