Source/modules/indexeddb/IDBObjectStore.cpp - Issue 718383003: bindings: fixed incorrect dependency of SerializedScriptValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/indexeddb/IDBObjectStore.cpp

Issue 718383003: bindings: fixed incorrect dependency of SerializedScriptValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptValueSerializer.cpp ('K') | « Source/core/testing/Internals.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/indexeddb/IDBObjectStore.cpp

diff --git a/Source/modules/indexeddb/IDBObjectStore.cpp b/Source/modules/indexeddb/IDBObjectStore.cpp

index 38ee016e6dae2b3461ca6b5aa0bde36c49f63b69..d8be73b1d08219523c3af88949e43ab0343f35cd 100644

--- a/Source/modules/indexeddb/IDBObjectStore.cpp

+++ b/Source/modules/indexeddb/IDBObjectStore.cpp

@@ -29,6 +29,7 @@

#include "bindings/core/v8/ExceptionState.h"

#include "bindings/core/v8/ExceptionStatePlaceholder.h"

#include "bindings/core/v8/ScriptState.h"

+#include "bindings/core/v8/SerializedScriptValueFactory.h"

#include "bindings/modules/v8/IDBBindingUtilities.h"

#include "core/dom/DOMStringList.h"

#include "core/dom/ExceptionCode.h"

@@ -177,7 +178,7 @@ IDBRequest* IDBObjectStore::put(ScriptState* scriptState, WebIDBPutMode putMode,

}

Vector<WebBlobInfo> blobInfo;

- RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValue::create(value, &blobInfo, exceptionState, scriptState->isolate());

+ RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValueFactory::instance().create(value, &blobInfo, exceptionState, scriptState->isolate());

if (exceptionState.hadException())

return 0;