Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp - Issue 718383003: bindings: fixed incorrect dependency of SerializedScriptValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

Issue 718383003: bindings: fixed incorrect dependency of SerializedScriptValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptValueSerializer.cpp ('K') | « Source/bindings/templates/interface.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

index 808d31081ebef69634af8fd3d996501d361e1d9f..12cadc068578b22ee1c1224b44094ed906815e5a 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

@@ -11,6 +11,7 @@

#include "bindings/core/v8/ExceptionState.h"

#include "bindings/core/v8/ScriptValue.h"

#include "bindings/core/v8/SerializedScriptValue.h"

+#include "bindings/core/v8/SerializedScriptValueFactory.h"

#include "bindings/core/v8/V8DOMConfiguration.h"

#include "bindings/core/v8/V8HiddenValue.h"

#include "bindings/core/v8/V8ObjectConstructor.h"

@@ -254,7 +255,7 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

return;

if (DOMWrapperWorld::current(info.GetIsolate()).isIsolatedWorld()) {

if (!initializedByEventConstructorReadonlyAnyAttribute.IsEmpty())

- event->setSerializedInitializedByEventConstructorReadonlyAnyAttribute(SerializedScriptValue::createAndSwallowExceptions(info.GetIsolate(), initializedByEventConstructorReadonlyAnyAttribute));

+ event->setSerializedInitializedByEventConstructorReadonlyAnyAttribute(SerializedScriptValueFactory::instance().createAndSwallowExceptions(info.GetIsolate(), initializedByEventConstructorReadonlyAnyAttribute));

}

v8::Handle<v8::Object> wrapper = info.Holder();