Source/bindings/core/v8/custom/V8HistoryCustom.cpp - Issue 718383003: bindings: fixed incorrect dependency of SerializedScriptValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8HistoryCustom.cpp

Issue 718383003: bindings: fixed incorrect dependency of SerializedScriptValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptValueSerializer.cpp ('K') | « Source/bindings/core/v8/custom/V8CustomEventCustom.cpp ('k') | Source/bindings/core/v8/custom/V8MessageEventCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8HistoryCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8HistoryCustom.cpp b/Source/bindings/core/v8/custom/V8HistoryCustom.cpp

index fd99d7bd6a60c665bf485bfee6d6d2f923adfa23..d6c99e308391d3837c73bbca45b6ee586527e908 100644

--- a/Source/bindings/core/v8/custom/V8HistoryCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8HistoryCustom.cpp

@@ -33,6 +33,7 @@

#include "bindings/core/v8/ExceptionState.h"

#include "bindings/core/v8/SerializedScriptValue.h"

+#include "bindings/core/v8/SerializedScriptValueFactory.h"

#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8HiddenValue.h"

#include "bindings/core/v8/V8Window.h"

@@ -62,7 +63,7 @@ void V8History::stateAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Va

void V8History::pushStateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

{

ExceptionState exceptionState(ExceptionState::ExecutionContext, "pushState", "History", info.Holder(), info.GetIsolate());

- RefPtr<SerializedScriptValue> historyState = SerializedScriptValue::create(info[0], 0, 0, exceptionState, info.GetIsolate());

+ RefPtr<SerializedScriptValue> historyState = SerializedScriptValueFactory::instance().create(info[0], 0, 0, exceptionState, info.GetIsolate());

if (exceptionState.throwIfNeeded())

return;

@@ -78,7 +79,7 @@ void V8History::pushStateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&

void V8History::replaceStateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

{

ExceptionState exceptionState(ExceptionState::ExecutionContext, "replaceState", "History", info.Holder(), info.GetIsolate());

- RefPtr<SerializedScriptValue> historyState = SerializedScriptValue::create(info[0], 0, 0, exceptionState, info.GetIsolate());

+ RefPtr<SerializedScriptValue> historyState = SerializedScriptValueFactory::instance().create(info[0], 0, 0, exceptionState, info.GetIsolate());

if (exceptionState.throwIfNeeded())

return;