Source/bindings/core/v8/custom/V8WindowCustom.cpp - Issue 718383003: bindings: fixed incorrect dependency of SerializedScriptValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 718383003: bindings: fixed incorrect dependency of SerializedScriptValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/SerializedScriptValueFactory.cpp ('K') | « Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp ('k') | Source/bindings/core/v8/v8.gypi » ('j') | Source/bindings/modules/v8/ScriptValueSerializerForModules.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8WindowCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/Source/bindings/core/v8/custom/V8WindowCustom.cpp

index 4c613dd51c7b494bebfb027ab4aa1a05f3f91dc0..561f365c266f81d672823b938fcabdaf3fef4121 100644

--- a/Source/bindings/core/v8/custom/V8WindowCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8WindowCustom.cpp

@@ -38,6 +38,7 @@

#include "bindings/core/v8/ScriptController.h"

#include "bindings/core/v8/ScriptSourceCode.h"

#include "bindings/core/v8/SerializedScriptValue.h"

+#include "bindings/core/v8/SerializedScriptValueFactory.h"

#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8EventListener.h"

#include "bindings/core/v8/V8EventListenerList.h"

@@ -281,7 +282,7 @@ void V8Window::postMessageMethodCustom(const v8::FunctionCallbackInfo<v8::Value>

}

TOSTRING_VOID(V8StringResource<TreatNullAndUndefinedAsNullString>, targetOrigin, info[targetOriginArgIndex]);

- RefPtr<SerializedScriptValue> message = SerializedScriptValue::create(info[0], &portArray, &arrayBufferArray, exceptionState, info.GetIsolate());

+ RefPtr<SerializedScriptValue> message = SerializedScriptValueFactory::factory().create(info[0], &portArray, &arrayBufferArray, exceptionState, info.GetIsolate());

if (exceptionState.throwIfNeeded())

return;