Source/bindings/core/v8/SerializedScriptValueTest.cpp - Issue 718383003: bindings: fixed incorrect dependency of SerializedScriptValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/SerializedScriptValueTest.cpp

Issue 718383003: bindings: fixed incorrect dependency of SerializedScriptValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/SerializedScriptValueFactory.cpp ('K') | « Source/bindings/core/v8/SerializedScriptValueFactory.cpp ('k') | Source/bindings/core/v8/custom/V8CustomEventCustom.cpp » ('j') | Source/bindings/modules/v8/ScriptValueSerializerForModules.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/SerializedScriptValueTest.cpp

diff --git a/Source/bindings/core/v8/SerializedScriptValueTest.cpp b/Source/bindings/core/v8/SerializedScriptValueTest.cpp

index 8b34b9e588beb4209c71d565e75076622242d926..d668195471c279ddd94d00fa801c68f07a216242 100644

--- a/Source/bindings/core/v8/SerializedScriptValueTest.cpp

+++ b/Source/bindings/core/v8/SerializedScriptValueTest.cpp

@@ -6,6 +6,7 @@

#include "bindings/core/v8/SerializedScriptValue.h"

#include "bindings/core/v8/ExceptionStatePlaceholder.h"

+#include "bindings/core/v8/SerializedScriptValueFactory.h"

#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8File.h"

#include "core/fileapi/File.h"

@@ -40,7 +41,7 @@ TEST_F(SerializedScriptValueTest, UserSelectedFile)

v8::Handle<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate());

RefPtr<SerializedScriptValue> serializedScriptValue =

- SerializedScriptValue::create(v8OriginalFile, nullptr, nullptr, ASSERT_NO_EXCEPTION, isolate());

+ SerializedScriptValueFactory::factory().create(v8OriginalFile, nullptr, nullptr, ASSERT_NO_EXCEPTION, isolate());

v8::Handle<v8::Value> v8File = serializedScriptValue->deserialize(isolate());

ASSERT_TRUE(V8File::hasInstance(v8File, isolate()));