Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: Source/bindings/core/v8/PostMessage.h

Issue 718383003: bindings: fixed incorrect dependency of SerializedScriptValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/PostMessage.h
diff --git a/Source/bindings/core/v8/PostMessage.h b/Source/bindings/core/v8/PostMessage.h
index b9f11b3b1bda4defd972c1b0b5f539484b60fae2..298458d5c5c33e10f9c21cda1160e480cde49a26 100644
--- a/Source/bindings/core/v8/PostMessage.h
+++ b/Source/bindings/core/v8/PostMessage.h
@@ -7,6 +7,7 @@
#include "bindings/core/v8/ExceptionState.h"
#include "bindings/core/v8/SerializedScriptValue.h"
+#include "bindings/core/v8/SerializedScriptValueFactory.h"
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8BindingMacros.h"
#include "core/dom/DOMArrayBuffer.h"
@@ -31,7 +32,7 @@ void postMessageMethodCommon(const char* interfaceName, Type* instance, const v8
return;
}
}
- RefPtr<SerializedScriptValue> message = SerializedScriptValue::create(info[0], &ports, &arrayBuffers, exceptionState, info.GetIsolate());
+ RefPtr<SerializedScriptValue> message = SerializedScriptValueFactory::factory().create(info[0], &ports, &arrayBuffers, exceptionState, info.GetIsolate());
haraken 2014/11/17 01:27:49 factory => instance (We normally use "instance" fo
tasak 2014/11/17 08:42:30 Done.
if (exceptionState.throwIfNeeded())
return;
// FIXME: Only pass context/exceptionState if instance really requires it.

Powered by Google App Engine
This is Rietveld 408576698