bindings: fixed incorrect dependency of SerializedScriptValue.

Source/bindings/core/v8/SerializedScriptValueFactory.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SerializedScriptValueFactory_h
+#define SerializedScriptValueFactory_h
+
+#include "bindings/core/v8/SerializedScriptValue.h"
+#include "wtf/Noncopyable.h"
+
+namespace blink {
+
+class SerializedScriptValueFactory {
+    WTF_MAKE_NONCOPYABLE(SerializedScriptValueFactory);
+public:
+    SerializedScriptValueFactory() { }
+
+    // If a serialization error occurs (e.g., cyclic input value) this
+    // function returns an empty representation, schedules a V8 exception to
+    // be thrown using v8::ThrowException(), and sets |didThrow|. In this case
+    // the caller must not invoke any V8 operations until control returns to
+    // V8. When serialization is successful, |didThrow| is false.
+    virtual PassRefPtr<SerializedScriptValue> create(v8::Handle<v8::Value>, MessagePortArray*, ArrayBufferArray*, ExceptionState&, v8::Isolate*);
+    virtual PassRefPtr<SerializedScriptValue> createFromWire(const String&);
+    PassRefPtr<SerializedScriptValue> createFromWireBytes(const Vector<uint8_t>&);
+    PassRefPtr<SerializedScriptValue> create(const String&);
+    virtual PassRefPtr<SerializedScriptValue> create(const String&, v8::Isolate*);
+    virtual PassRefPtr<SerializedScriptValue> create();
+    virtual PassRefPtr<SerializedScriptValue> create(const ScriptValue&, WebBlobInfoArray*, ExceptionState&, v8::Isolate*);
+
+    // Never throws exceptions.
+    PassRefPtr<SerializedScriptValue> createAndSwallowExceptions(v8::Isolate*, v8::Handle<v8::Value>);
+
+    static SerializedScriptValueFactory& factory()
+    {

[haraken, 2014/11/17 01:27:49]

Shouldn't this be ASSERT_NOT_REACHED()?

I guess SerializedScriptValueFactory::factory() should not be called before
SerializedScriptValueFactory::initialize() is called.

[tasak, 2014/11/17 08:42:30]

Done.

+        if (!m_singleton)
+            m_singleton = new SerializedScriptValueFactory();
+        return *m_singleton;
+    }
+
+    static void initialize(SerializedScriptValueFactory* newFactory)

[tasak, 2014/11/14 08:07:39]

initialize is invoked when Blink is initlized. i.e. initializeWithoutV8 in
WebKit.cpp.

initializeWithoutV8() => init() in ModulesInitializer (InitModules.h, cpp) =>
ModuleBindingsInitializer::init() =>
SerializedScriptValueFactory::initialize(new
SerializedScriptValueForModulesFactory)

[haraken, 2014/11/17 01:27:50]

Add a comment about this behavior.

[tasak, 2014/11/17 08:42:30]

Done.

+    {
+        ASSERT(!m_singleton);
+        m_singleton = newFactory;
+    }
+
+private:
+    static SerializedScriptValueFactory* m_singleton;
+};
+
+} // namespace blink
+
+#endif // SerializedScriptValueFactory_h
+