Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: Source/bindings/core/v8/SerializedScriptValueTest.cpp

Issue 718383003: bindings: fixed incorrect dependency of SerializedScriptValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added fast/js/structured-clone.html Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "bindings/core/v8/SerializedScriptValue.h" 6 #include "bindings/core/v8/SerializedScriptValue.h"
7 7
8 #include "bindings/core/v8/ExceptionStatePlaceholder.h" 8 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
9 #include "bindings/core/v8/SerializedScriptValueFactory.h"
9 #include "bindings/core/v8/V8Binding.h" 10 #include "bindings/core/v8/V8Binding.h"
10 #include "bindings/core/v8/V8File.h" 11 #include "bindings/core/v8/V8File.h"
11 #include "core/fileapi/File.h" 12 #include "core/fileapi/File.h"
12 #include "public/platform/Platform.h" 13 #include "public/platform/Platform.h"
13 #include "public/platform/WebUnitTestSupport.h" 14 #include "public/platform/WebUnitTestSupport.h"
14 #include <gtest/gtest.h> 15 #include <gtest/gtest.h>
15 16
16 namespace blink { 17 namespace blink {
17 18
18 class SerializedScriptValueTest : public ::testing::Test { 19 class SerializedScriptValueTest : public ::testing::Test {
(...skipping 14 matching lines...) Expand all
33 { 34 {
34 String filePath = Platform::current()->unitTestSupport()->webKitRootDir(); 35 String filePath = Platform::current()->unitTestSupport()->webKitRootDir();
35 filePath.append("/Source/bindings/core/v8/SerializedScriptValueTest.cpp"); 36 filePath.append("/Source/bindings/core/v8/SerializedScriptValueTest.cpp");
36 File* originalFile = File::create(filePath); 37 File* originalFile = File::create(filePath);
37 ASSERT_TRUE(originalFile->hasBackingFile()); 38 ASSERT_TRUE(originalFile->hasBackingFile());
38 ASSERT_EQ(File::IsUserVisible, originalFile->userVisibility()); 39 ASSERT_EQ(File::IsUserVisible, originalFile->userVisibility());
39 ASSERT_EQ(filePath, originalFile->path()); 40 ASSERT_EQ(filePath, originalFile->path());
40 41
41 v8::Handle<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate()); 42 v8::Handle<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate());
42 RefPtr<SerializedScriptValue> serializedScriptValue = 43 RefPtr<SerializedScriptValue> serializedScriptValue =
43 SerializedScriptValue::create(v8OriginalFile, nullptr, nullptr, ASSERT_N O_EXCEPTION, isolate()); 44 SerializedScriptValueFactory::instance().create(v8OriginalFile, nullptr, nullptr, ASSERT_NO_EXCEPTION, isolate());
44 v8::Handle<v8::Value> v8File = serializedScriptValue->deserialize(isolate()) ; 45 v8::Handle<v8::Value> v8File = serializedScriptValue->deserialize(isolate()) ;
45 46
46 ASSERT_TRUE(V8File::hasInstance(v8File, isolate())); 47 ASSERT_TRUE(V8File::hasInstance(v8File, isolate()));
47 File* file = V8File::toImpl(v8::Handle<v8::Object>::Cast(v8File)); 48 File* file = V8File::toImpl(v8::Handle<v8::Object>::Cast(v8File));
48 EXPECT_TRUE(file->hasBackingFile()); 49 EXPECT_TRUE(file->hasBackingFile());
49 EXPECT_EQ(File::IsUserVisible, file->userVisibility()); 50 EXPECT_EQ(File::IsUserVisible, file->userVisibility());
50 EXPECT_EQ(filePath, file->path()); 51 EXPECT_EQ(filePath, file->path());
51 } 52 }
52 53
53 TEST_F(SerializedScriptValueTest, FileConstructorFile) 54 TEST_F(SerializedScriptValueTest, FileConstructorFile)
54 { 55 {
55 RefPtr<BlobDataHandle> blobDataHandle = BlobDataHandle::create(); 56 RefPtr<BlobDataHandle> blobDataHandle = BlobDataHandle::create();
56 File* originalFile = File::create("hello.txt", 12345678.0, blobDataHandle); 57 File* originalFile = File::create("hello.txt", 12345678.0, blobDataHandle);
57 ASSERT_FALSE(originalFile->hasBackingFile()); 58 ASSERT_FALSE(originalFile->hasBackingFile());
58 ASSERT_EQ(File::IsNotUserVisible, originalFile->userVisibility()); 59 ASSERT_EQ(File::IsNotUserVisible, originalFile->userVisibility());
59 ASSERT_EQ("hello.txt", originalFile->name()); 60 ASSERT_EQ("hello.txt", originalFile->name());
60 61
61 v8::Handle<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate()); 62 v8::Handle<v8::Value> v8OriginalFile = toV8(originalFile, creationContext(), isolate());
62 RefPtr<SerializedScriptValue> serializedScriptValue = 63 RefPtr<SerializedScriptValue> serializedScriptValue =
63 SerializedScriptValue::create(v8OriginalFile, nullptr, nullptr, ASSERT_N O_EXCEPTION, isolate()); 64 SerializedScriptValueFactory::instance().create(v8OriginalFile, nullptr, nullptr, ASSERT_NO_EXCEPTION, isolate());
64 v8::Handle<v8::Value> v8File = serializedScriptValue->deserialize(isolate()) ; 65 v8::Handle<v8::Value> v8File = serializedScriptValue->deserialize(isolate()) ;
65 66
66 ASSERT_TRUE(V8File::hasInstance(v8File, isolate())); 67 ASSERT_TRUE(V8File::hasInstance(v8File, isolate()));
67 File* file = V8File::toImpl(v8::Handle<v8::Object>::Cast(v8File)); 68 File* file = V8File::toImpl(v8::Handle<v8::Object>::Cast(v8File));
68 EXPECT_FALSE(file->hasBackingFile()); 69 EXPECT_FALSE(file->hasBackingFile());
69 EXPECT_EQ(File::IsNotUserVisible, file->userVisibility()); 70 EXPECT_EQ(File::IsNotUserVisible, file->userVisibility());
70 EXPECT_EQ("hello.txt", file->name()); 71 EXPECT_EQ("hello.txt", file->name());
71 } 72 }
72 73
73 } // namespace blink 74 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/SerializedScriptValueFactory.cpp ('k') | Source/bindings/core/v8/custom/V8CustomEventCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698