Issue 718303002: GCM Directive fix (M40 merge)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 718303002: GCM Directive fix (M40 merge) (Closed)

Created:
6 years, 1 month ago by Charlie

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2214

Project:
chromium

Visibility:
Public.

GCM Directive fix. We need to handle directives without op ids, but we should limit their TTL. BUG=431871 TBR=matthewyuan@chromium.org,rkc@chromium.org Review URL: https://codereview.chromium.org/710183003 Cr-Commit-Position: refs/heads/master@{#303542} (cherry picked from commit 9baadc9a0fe2f708d553070605d388547f5c3446) Committed: https://chromium.googlesource.com/chromium/src/+/8c9d1ebc4a554fbde1581bebff32e8e6e46bfd33

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -6 lines)			Patch
	M	components/copresence/handlers/directive_handler.cc	View		4 chunks	+25 lines, -3 lines	0 comments	Download
	M	components/copresence/handlers/directive_handler_unittest.cc	View		6 chunks	+40 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)

Charlie

6 years, 1 month ago (2014-11-13 02:41:11 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8c9d1ebc4a554fbde1581bebff32e8e6e46bfd33 (presubmit successful).