net/base/ip_endpoint.h - Issue 718273002: Use uint16 for port numbers, net/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/ip_endpoint.h

Issue 718273002: Use uint16 for port numbers, net/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/ip_endpoint.h

diff --git a/net/base/ip_endpoint.h b/net/base/ip_endpoint.h

index 5e5d9c19684e63a27959ee8cdd85eb5d9a202bc9..c2639b161d6f41dac152be0e7007afb484c5d4c9 100644

--- a/net/base/ip_endpoint.h

+++ b/net/base/ip_endpoint.h

@@ -24,11 +24,11 @@ class NET_EXPORT IPEndPoint {

public:

IPEndPoint();

~IPEndPoint();

- IPEndPoint(const IPAddressNumber& address, int port);

+ IPEndPoint(const IPAddressNumber& address, uint16 port);

IPEndPoint(const IPEndPoint& endpoint);

mmenke 2014/11/19 15:29:21 While you're here, mind adding explicit to the las

const IPAddressNumber& address() const { return address_; }

- int port() const { return port_; }

+ uint16 port() const { return port_; }

// Returns AddressFamily of the address.

AddressFamily GetFamily() const;

@@ -66,7 +66,7 @@ class NET_EXPORT IPEndPoint {

private:

IPAddressNumber address_;

- int port_;

+ uint16 port_;

};

} // namespace net

« no previous file with comments | « net/base/host_port_pair.cc ('k') | net/base/ip_endpoint.cc » ('j') | no next file with comments »