net/socket/client_socket_pool_manager.cc - Issue 718273002: Use uint16 for port numbers, net/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_pool_manager.cc

Issue 718273002: Use uint16 for port numbers, net/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/client_socket_pool_manager.cc

diff --git a/net/socket/client_socket_pool_manager.cc b/net/socket/client_socket_pool_manager.cc

index b99612718e47ade9cc598c4996a141cd054c140b..1acb2ef832ebc55ac59a6a9cb398429288ffc721 100644

--- a/net/socket/client_socket_pool_manager.cc

+++ b/net/socket/client_socket_pool_manager.cc

@@ -93,7 +93,7 @@ int InitSocketPoolHelper(const GURL& request_url,

HostPortPair origin_host_port =

HostPortPair(request_url.HostNoBrackets(),

- request_url.EffectiveIntPort());

+ static_cast<uint16>(request_url.EffectiveIntPort()));

mmenke 2014/11/18 21:06:39 HostPortPair::FromURL

Peter Kasting 2014/11/18 23:38:42 Done.

if (!using_ssl && session->params().testing_fixed_http_port != 0) {

origin_host_port.set_port(session->params().testing_fixed_http_port);