net/http/http_stream_factory_impl.cc - Issue 718273002: Use uint16 for port numbers, net/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl.cc

Issue 718273002: Use uint16 for port numbers, net/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_factory_impl.cc

diff --git a/net/http/http_stream_factory_impl.cc b/net/http/http_stream_factory_impl.cc

index 83046944ac2e25ab56c81bb92dee2bbea425e69c..ffaf2502100348ec64d6f16a3fc23f5d3afb4545 100644

--- a/net/http/http_stream_factory_impl.cc

+++ b/net/http/http_stream_factory_impl.cc

@@ -184,8 +184,9 @@ AlternateProtocolInfo HttpStreamFactoryImpl::GetAlternateProtocolRequestFor(

if (original_url.SchemeIs("ftp"))

return kNoAlternateProtocol;

- HostPortPair origin = HostPortPair(original_url.HostNoBrackets(),

- original_url.EffectiveIntPort());

+ HostPortPair origin = HostPortPair(

+ original_url.HostNoBrackets(),

+ static_cast<uint16>(original_url.EffectiveIntPort()));

mmenke 2014/11/18 21:06:39 HostPortPair::FromURL(original_url)

Peter Kasting 2014/11/18 23:38:42 Done.

HttpServerProperties& http_server_properties =

*session_->http_server_properties();