net/http/http_network_transaction.cc - Issue 718273002: Use uint16 for port numbers, net/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction.cc

Issue 718273002: Use uint16 for port numbers, net/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_network_transaction.cc

diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc

index 20ffdd14f1755a2511bc3340acf060728bb66e7f..348e4fef0df13ad6b41eefba4d0495b69cefd29c 100644

--- a/net/http/http_network_transaction.cc

+++ b/net/http/http_network_transaction.cc

@@ -1027,8 +1027,9 @@ int HttpNetworkTransaction::DoReadHeadersComplete(int result) {

return OK;

}

- HostPortPair endpoint = HostPortPair(request_->url.HostNoBrackets(),

- request_->url.EffectiveIntPort());

+ HostPortPair endpoint = HostPortPair(

+ request_->url.HostNoBrackets(),

+ static_cast<uint16>(request_->url.EffectiveIntPort()));

mmenke 2014/11/18 21:06:39 HostPortPair::FromURL(request.url)

Peter Kasting 2014/11/18 23:38:42 Done.

ProcessAlternateProtocol(session_,

*response_.headers.get(),

endpoint);