net/base/host_mapping_rules.cc - Issue 718273002: Use uint16 for port numbers, net/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/host_mapping_rules.cc

Issue 718273002: Use uint16 for port numbers, net/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/host_mapping_rules.cc

diff --git a/net/base/host_mapping_rules.cc b/net/base/host_mapping_rules.cc

index f91f3fd0b4e7e2547123d50b72fe6ecbe5ce079a..01b98b7b2445e200288759cdafdc252579aded97 100644

--- a/net/base/host_mapping_rules.cc

+++ b/net/base/host_mapping_rules.cc

@@ -58,7 +58,7 @@ bool HostMappingRules::RewriteHost(HostPortPair* host_port) const {

host_port->set_host(rule.replacement_hostname);

if (rule.replacement_port != -1)

- host_port->set_port(rule.replacement_port);

+ host_port->set_port(static_cast<uint16>(rule.replacement_port));

Peter Kasting 2014/11/12 23:54:31 ParseHostAndPort() guarantees that this number wil

return true;

}

« no previous file with comments | « no previous file | net/base/host_port_pair.cc » ('j') | net/base/ip_endpoint_unittest.cc » ('J')