Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

Issue 718273002: Use uint16 for port numbers, net/ edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/base/host_mapping_rules.cc » ('j') | net/base/ip_endpoint.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/socket/tcp_socket.h" 5 #include "extensions/browser/api/socket/tcp_socket.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "net/base/address_list.h" 8 #include "net/base/address_list.h"
9 #include "net/base/completion_callback.h" 9 #include "net/base/completion_callback.h"
10 #include "net/base/io_buffer.h" 10 #include "net/base/io_buffer.h"
(...skipping 25 matching lines...) Expand all
36 virtual bool IsConnected() const override { 36 virtual bool IsConnected() const override {
37 return true; 37 return true;
38 } 38 }
39 39
40 private: 40 private:
41 DISALLOW_COPY_AND_ASSIGN(MockTCPSocket); 41 DISALLOW_COPY_AND_ASSIGN(MockTCPSocket);
42 }; 42 };
43 43
44 class MockTCPServerSocket : public net::TCPServerSocket { 44 class MockTCPServerSocket : public net::TCPServerSocket {
45 public: 45 public:
46 explicit MockTCPServerSocket() 46 MockTCPServerSocket() : net::TCPServerSocket(NULL, net::NetLog::Source()) {
47 : net::TCPServerSocket(NULL, net::NetLog::Source()) {
48 } 47 }
49 MOCK_METHOD2(Listen, int(const net::IPEndPoint& address, int backlog)); 48 MOCK_METHOD2(Listen, int(const net::IPEndPoint& address, int backlog));
50 MOCK_METHOD2(Accept, int(scoped_ptr<net::StreamSocket>* socket, 49 MOCK_METHOD2(Accept, int(scoped_ptr<net::StreamSocket>* socket,
51 const net::CompletionCallback& callback)); 50 const net::CompletionCallback& callback));
52 51
53 private: 52 private:
54 DISALLOW_COPY_AND_ASSIGN(MockTCPServerSocket); 53 DISALLOW_COPY_AND_ASSIGN(MockTCPServerSocket);
55 }; 54 };
56 55
57 class CompleteHandler { 56 class CompleteHandler {
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 EXPECT_CALL(*tcp_server_socket, Listen(_, _)).Times(1); 224 EXPECT_CALL(*tcp_server_socket, Listen(_, _)).Times(1);
226 EXPECT_CALL(handler, OnAccept(_, _)); 225 EXPECT_CALL(handler, OnAccept(_, _));
227 226
228 std::string err_msg; 227 std::string err_msg;
229 EXPECT_EQ(net::OK, socket->Listen("127.0.0.1", 9999, 10, &err_msg)); 228 EXPECT_EQ(net::OK, socket->Listen("127.0.0.1", 9999, 10, &err_msg));
230 socket->Accept(base::Bind(&CompleteHandler::OnAccept, 229 socket->Accept(base::Bind(&CompleteHandler::OnAccept,
231 base::Unretained(&handler))); 230 base::Unretained(&handler)));
232 } 231 }
233 232
234 } // namespace extensions 233 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | net/base/host_mapping_rules.cc » ('j') | net/base/ip_endpoint.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698