Use uint16 for port numbers, net/ edition

net/spdy/hpack_huffman_aggregator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "net/spdy/hpack_huffman_aggregator.h"
 
 #include "base/metrics/bucket_ranges.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/sample_vector.h"
 #include "base/stl_util.h"
@@ skipping 31 matching lines @@
 }
 
 void HpackHuffmanAggregator::AggregateTransactionCharacterCounts(
     const HttpRequestInfo& request,
     const HttpRequestHeaders& request_headers,
     const ProxyServer& proxy,
     const HttpResponseHeaders& response_headers) {
   if (IsCrossOrigin(request)) {
     return;
   }
-  HostPortPair endpoint = HostPortPair(request.url.HostNoBrackets(),
-                                       request.url.EffectiveIntPort());
+  HostPortPair endpoint = HostPortPair(
+      request.url.HostNoBrackets(),
+      static_cast<uint16>(request.url.EffectiveIntPort()));

[mmenke, 2014/11/18 21:06:39]

While you're here, this is just HostPortPair::FromURL(request.url)

[Peter Kasting, 2014/11/18 23:38:43]

Done.

   HpackEncoder* encoder = ObtainEncoder(
       SpdySessionKey(endpoint, proxy, request.privacy_mode));
 
   // Convert and encode the request and response header sets.
   {
     SpdyHeaderBlock headers;
     CreateSpdyHeadersFromHttpRequest(
         request, request_headers, SPDY4, false, &headers);
 
     std::string tmp_out;
@@ skipping 37 matching lines @@
       (*headers_out)[name] += std::string(1, '\0') + value;
     }
   }
   (*headers_out)[":status"] = base::IntToString(headers.response_code());
 }
 
 // static
 bool HpackHuffmanAggregator::IsCrossOrigin(const HttpRequestInfo& request) {
   // Require that the request is top-level, or that it shares
   // an origin with its referer.
-  HostPortPair endpoint = HostPortPair(request.url.HostNoBrackets(),
-                                       request.url.EffectiveIntPort());
+  HostPortPair endpoint = HostPortPair(
+      request.url.HostNoBrackets(),
+      static_cast<uint16>(request.url.EffectiveIntPort()));

[mmenke, 2014/11/18 21:06:39]

HostPortPair::FromURL(request.url)

[Peter Kasting, 2014/11/18 23:38:43]

Done.

   if ((request.load_flags & LOAD_MAIN_FRAME) == 0) {
     std::string referer_str;
     if (!request.extra_headers.GetHeader(HttpRequestHeaders::kReferer,
                                          &referer_str)) {
       // Require a referer.
       return true;
     }
     GURL referer(referer_str);
-    HostPortPair referer_endpoint = HostPortPair(referer.HostNoBrackets(),
-                                                 referer.EffectiveIntPort());
+    HostPortPair referer_endpoint = HostPortPair(
+        referer.HostNoBrackets(),
+        static_cast<uint16>(referer.EffectiveIntPort()));

[mmenke, 2014/11/18 21:06:39]

HostPortPair::FromURL(request.url)

[Peter Kasting, 2014/11/18 23:38:43]

Done.

     if (!endpoint.Equals(referer_endpoint)) {
       // Cross-origin request.
       return true;
     }
   }
   return false;
 }
 
 HpackEncoder* HpackHuffmanAggregator::ObtainEncoder(const SpdySessionKey& key) {
   for (OriginEncoders::iterator it = encoders_.begin();
@@ skipping 41 matching lines @@
       base::LinearHistogram::FactoryGet(
           kHistogramName, kRangeMin, kRangeMax, kBucketCount,
           base::HistogramBase::kUmaTargetedHistogramFlag));
 
   // Clear counts.
   counts_.assign(counts_.size(), 0);
   total_counts_ = 0;
 }
 
 }  // namespace net