chrome/installer/util/shell_util.cc - Issue 718253002: Remove implicit conversions from scoped_refptr to T* in chrome/installer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/shell_util.cc

Issue 718253002: Remove implicit conversions from scoped_refptr to T* in chrome/installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/shell_util.cc

diff --git a/chrome/installer/util/shell_util.cc b/chrome/installer/util/shell_util.cc

index fd1a6c35d1f328603487641476e10f2d7f2fecae..f386cd025ef4ddae8b81a34ee2e94388845cd754 100644

--- a/chrome/installer/util/shell_util.cc

+++ b/chrome/installer/util/shell_util.cc

@@ -1490,7 +1490,7 @@ bool BatchShortcutAction(

for (base::FilePath shortcut_path = enumerator.Next();

!shortcut_path.empty();

shortcut_path = enumerator.Next()) {

- if (cancel && cancel->data.IsSet())

+ if (cancel.get() && cancel->data.IsSet())

return false;

if (base::win::ResolveShortcut(shortcut_path, &target_path, &args)) {

if (shortcut_filter.Run(target_path, args) &&

« no previous file with comments | « chrome/installer/util/legacy_firewall_manager_win.cc ('k') | chrome/installer/util/wmi.cc » ('j') | no next file with comments »