Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 718203002: Use "unsigned" rather than "unsigned long" for C++ code interacting with WebIDL's "unsigned long". (Closed)

Created:
6 years, 1 month ago by eroman
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, tyoshino+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Use "unsigned" rather than "unsigned long" for C++ code interacting with WebIDL's "unsigned long". (WebIDL's "unsigned long" is a 32-bit type) BUG=267360 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185257

Patch Set 1 #

Patch Set 2 : use uint32_t instead of unsigned #

Patch Set 3 : Change back to unsigned #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/xmlhttprequest/XMLHttpRequest.h View 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
eroman
This is a first of a number of instances I would like to fix. Do ...
6 years, 1 month ago (2014-11-12 20:31:40 UTC) #2
haraken
On 2014/11/12 20:31:40, eroman wrote: > This is a first of a number of instances ...
6 years, 1 month ago (2014-11-12 23:26:32 UTC) #3
eroman
Done -- changed to unsigned
6 years, 1 month ago (2014-11-12 23:30:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718203002/40001
6 years, 1 month ago (2014-11-12 23:31:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718203002/40001
6 years, 1 month ago (2014-11-12 23:37:03 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 00:54:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 185257

Powered by Google App Engine
This is Rietveld 408576698