test/cctest/compiler/test-js-typed-lowering.cc - Issue 718193003: [turbofan] Avoid useless bit masking in typed lowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-js-typed-lowering.cc

Issue 718193003: [turbofan] Avoid useless bit masking in typed lowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/compiler/test-js-typed-lowering.cc

diff --git a/test/cctest/compiler/test-js-typed-lowering.cc b/test/cctest/compiler/test-js-typed-lowering.cc

index 7c04cf3de7b70fad6d27f1329c86c956781281d8..ee69e1743b946e6dbf501eb5f6bb2f8695810d51 100644

--- a/test/cctest/compiler/test-js-typed-lowering.cc

+++ b/test/cctest/compiler/test-js-typed-lowering.cc

@@ -327,9 +327,13 @@ TEST(Int32BitwiseShifts) {

CheckToI32(p0, r0, R.signedness[k]);

- R.CheckPureBinop(IrOpcode::kWord32And, r1);

- CheckToI32(p1, r1->InputAt(0), R.signedness[k + 1]);

- R.CheckInt32Constant(0x1F, r1->InputAt(1));

+ if (r1->opcode() == IrOpcode::kWord32And) {

+ R.CheckPureBinop(IrOpcode::kWord32And, r1);

+ CheckToI32(p1, r1->InputAt(0), R.signedness[k + 1]);

+ R.CheckInt32Constant(0x1F, r1->InputAt(1));

+ } else {

+ CheckToI32(p1, r1, R.signedness[k]);

+ }

}