Issue 718193003: [turbofan] Avoid useless bit masking in typed lowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 718193003: [turbofan] Avoid useless bit masking in typed lowering. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer

Modified:
6 years, 1 month ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

[turbofan] Avoid useless bit masking in typed lowering. There's no need to apply the 0x1f mask to right hand sides of shifts if the input is already in range [0,31]. TEST=cctest,unittests R=jarin@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/7205f6ee9b795502b953c5545ebe2541980a9ebe

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -5 lines)			Patch
M	src/compiler/js-typed-lowering.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/js-typed-lowering.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	test/cctest/compiler/test-js-typed-lowering.cc	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	test/unittests/compiler/js-typed-lowering-unittest.cc	View	1 chunk	+99 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

6 years, 1 month ago (2014-11-13 07:41:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7205f6ee9b795502b953c5545ebe2541980a9ebe (presubmit successful).