Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 718153002: Indicate whether a touch event will cause scrolling (Closed)

Created:
6 years, 1 month ago by jdduke (slow)
Modified:
6 years ago
Reviewers:
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, sadrul, tdresser+watch_chromium.org, James Su, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Indicate whether a touch event will cause scrolling With the eager GR, we know the default actions of a touch event before it is forwarded to a given target. For now, flag each touch event to indicate whether it will cause scrolling (if unhandled). This is particularly useful for decoupling the redundant slop region checks we have in the code to try to guess whether a given touch sequence has started or may start scrolling. BUG=425586, 432605

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -198 lines) Patch
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_config_helper.cc View 3 chunks +2 lines, -18 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator.cc View 9 chunks +21 lines, -21 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 6 chunks +11 lines, -38 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 9 chunks +18 lines, -49 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util.h View 1 chunk +3 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/web_input_event_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/ui_events_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/input/web_input_event_traits.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/event.h View 3 chunks +11 lines, -2 lines 0 comments Download
M ui/events/event.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M ui/events/events.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/gesture_detection/filtered_gesture_provider.h View 3 chunks +17 lines, -4 lines 0 comments Download
M ui/events/gesture_detection/filtered_gesture_provider.cc View 2 chunks +23 lines, -8 lines 0 comments Download
A ui/events/gesture_detection/filtered_gesture_provider_unittest.cc View 1 chunk +84 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_detector.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/gesture_detection/scale_gesture_detector.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/gestures/gesture_provider_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gestures/gesture_provider_aura.cc View 2 chunks +17 lines, -12 lines 0 comments Download
M ui/events/gestures/gesture_provider_aura_unittest.cc View 8 chunks +15 lines, -13 lines 0 comments Download
M ui/events/gestures/gesture_recognizer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698