Issue 718123002: Use loops directly in apptest main files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 718123002: Use loops directly in apptest main files. (Closed)

Created:
6 years, 1 month ago by msw

Modified:
6 years, 1 month ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Use loops directly in apptest main files. Use mojo::RunLoop in application_test_main.cc Use base::MessageLoop in application_test_main_chromium.cc Avoid Environment's DefaultRunLoop abstraction. This follows some code review feedback from: https://codereview.chromium.org/710403002/ BUG=392646 TEST=apptests still build and run fine. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6d1f41d5db60e3c295ce61394bcb2154bfee620f

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -23 lines)			Patch
M	mojo/application/BUILD.gn	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	mojo/application/application_test_main_chromium.cc	View	3 chunks	+7 lines, -8 lines	0 comments	Download
M	mojo/public/cpp/application/BUILD.gn	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	mojo/public/cpp/application/lib/DEPS	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	mojo/public/cpp/application/lib/application_test_main.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

msw

6 years, 1 month ago (2014-11-12 17:45:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6d1f41d5db60e3c295ce61394bcb2154bfee620f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages