Introduce the NotificationEvent object.

Introduce the NotificationEvent object.

Notification events delivered to Service Workers (notificationclick
and notificationerror) will receive an instance of the Notification
object which they were triggered for, represented through a
NotificationEvent. It's of the SW ExtendableEvent type.

BUG=432527
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185296

[Peter Beverloo, 2014-11-12 15:39:57]

peter@chromium.org changed reviewers:
+ mkwst@chromium.org, mvanouwerkerk@chromium.org

[Peter Beverloo, 2014-11-12 15:39:58]

PTAL

[Michael van Ouwerkerk, 2014-11-12 18:03:01]

lgtm

What's your test plan?

[Mike West, 2014-11-13 09:56:16]

The code looks fine, but mvanouwerkerk@ is totally right. There should at least
be a test showing that this is exposed in the right places.

[blink-reviews, 2014-11-13 10:21:00]

I'm not sure this is meaningfully testable without follow-up patches, so
I'll take 'later' for an answer. I'd like to know what the plan is though,
like what else needs to land.
On Nov 13, 2014 9:56 AM, <mkwst@chromium.org> wrote:

> The code looks fine, but mvanouwerkerk@ is totally right. There should at
> least
> be a test showing that this is exposed in the right places.
>
> https://codereview.chromium.org/718093002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Peter Beverloo, 2014-11-13 14:10:59]

On 2014/11/13 10:21:00, blink-reviews wrote:
> I'm not sure this is meaningfully testable without follow-up patches, so
> I'll take 'later' for an answer. I'd like to know what the plan is though,
> like what else needs to land.
> On Nov 13, 2014 9:56 AM, <mailto:mkwst@chromium.org> wrote:
> 
> > The code looks fine, but mvanouwerkerk@ is totally right. There should at
> > least
> > be a test showing that this is exposed in the right places.
> >
> > https://codereview.chromium.org/718093002/
> >
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to mailto:blink-reviews+unsubscribe@chromium.org.
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:blink-reviews+unsubscribe@chromium.org.

I added a test, which will be extended once the constructor lands. Mike: PTAL?
:-)

[Mike West, 2014-11-13 14:16:22]

LGTM. :)

[Peter Beverloo, 2014-11-13 14:16:43]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2014-11-13 14:17:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/718093002/20001

[commit-bot: I haz the power, 2014-11-13 15:24:41]

Committed patchset #2 (id:20001) as 185296