Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Issue 718043007: PasswordManager should not check the landing page for login form repetition for non-HTML forms (Closed)

Created:
6 years, 1 month ago by Sunil Ratnu
Modified:
6 years, 1 month ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PasswordManager should not check the landing page for login form repetition for non-HTML forms The current check in PasswordManager::OnPasswordFormsRendered, which tries to find a form similar to the one provisionally saved makes no sense for non-HTML forms, and should be skipped for those. BUG=432594 Committed: https://crrev.com/1d18362765ffabee2cc9ea9d3c63db763d7ea6a2 Cr-Commit-Position: refs/heads/master@{#304803}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addresed Vaclav's review comments #

Total comments: 2

Patch Set 3 : Added log message #

Total comments: 2

Patch Set 4 : Typo correction: s/NON/NOT #

Patch Set 5 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M components/autofill/core/common/save_password_progress_logger.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/common/save_password_progress_logger.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 1 2 3 4 1 chunk +24 lines, -18 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
Sunil Ratnu
Hi Vaclav, Please review this. Thanks! Sunil
6 years, 1 month ago (2014-11-18 13:06:23 UTC) #2
vabr (Chromium)
Thanks, I left one comment. Exceptionally, I think it is fine to not add tests: ...
6 years, 1 month ago (2014-11-18 14:46:25 UTC) #3
Sunil Ratnu
Thanks Vaclav for the review. Please review the latest patchset. Thanks! Sunil https://codereview.chromium.org/718043007/diff/1/components/password_manager/core/browser/password_manager.cc File components/password_manager/core/browser/password_manager.cc ...
6 years, 1 month ago (2014-11-19 07:07:35 UTC) #4
vabr (Chromium)
Thanks, Sunil Ratnu! Please see my comment and response below. Cheers, Vaclav https://codereview.chromium.org/718043007/diff/1/components/password_manager/core/browser/password_manager.cc File components/password_manager/core/browser/password_manager.cc ...
6 years, 1 month ago (2014-11-19 09:47:12 UTC) #5
Sunil Ratnu
Hi Vaclav, I've made the suggested changes. please review the latest patchset. Thanks! Sunil https://codereview.chromium.org/718043007/diff/20001/components/password_manager/core/browser/password_manager.cc ...
6 years, 1 month ago (2014-11-19 10:37:27 UTC) #7
vabr (Chromium)
LGTM, with an optional comment. Thanks! Vaclav https://codereview.chromium.org/718043007/diff/60001/components/autofill/core/common/save_password_progress_logger.cc File components/autofill/core/common/save_password_progress_logger.cc (right): https://codereview.chromium.org/718043007/diff/60001/components/autofill/core/common/save_password_progress_logger.cc#newcode180 components/autofill/core/common/save_password_progress_logger.cc:180: SavePasswordProgressLogger::STRING_PROVISIONALLY_SAVED_FORM_IS_NON_HTML: optional ...
6 years, 1 month ago (2014-11-19 12:45:49 UTC) #8
Sunil Ratnu
Thanks for the review. I've made the suggested changes. Thanks! Sunil https://codereview.chromium.org/718043007/diff/60001/components/autofill/core/common/save_password_progress_logger.cc File components/autofill/core/common/save_password_progress_logger.cc (right): ...
6 years, 1 month ago (2014-11-19 12:50:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718043007/80001
6 years, 1 month ago (2014-11-19 12:52:12 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/35312)
6 years, 1 month ago (2014-11-19 12:58:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/718043007/100001
6 years, 1 month ago (2014-11-19 13:01:59 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:100001)
6 years, 1 month ago (2014-11-19 14:10:54 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 14:11:30 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1d18362765ffabee2cc9ea9d3c63db763d7ea6a2
Cr-Commit-Position: refs/heads/master@{#304803}

Powered by Google App Engine
This is Rietveld 408576698