Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1317)

Unified Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 718033002: DevTools: NetworkPanel: do not show out-of-range dividers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/network/NetworkPanel.js
diff --git a/Source/devtools/front_end/network/NetworkPanel.js b/Source/devtools/front_end/network/NetworkPanel.js
index 73ce990a5957e8ac0cb5eaa0271ee4bbe403dadc..e9e8dcb8f0c5f83334aa2c0512f4f752765baacf 100644
--- a/Source/devtools/front_end/network/NetworkPanel.js
+++ b/Source/devtools/front_end/network/NetworkPanel.js
@@ -656,32 +656,22 @@ WebInspector.NetworkLogView.prototype = {
}
this._timelineGrid.removeEventDividers();
- if (this._mainRequestLoadTime !== -1) {
- var percent = calculator.computePercentageFromEventTime(this._mainRequestLoadTime);
-
- var loadDivider = createElement("div");
- loadDivider.className = "network-event-divider network-red-divider";
-
- var loadDividerPadding = createElement("div");
- loadDividerPadding.className = "network-event-divider-padding";
- loadDividerPadding.title = WebInspector.UIString("Load event");
- loadDividerPadding.appendChild(loadDivider);
- loadDividerPadding.style.left = percent + "%";
- this._timelineGrid.addEventDivider(loadDividerPadding);
- }
-
- if (this._mainRequestDOMContentLoadedTime !== -1) {
- var percent = calculator.computePercentageFromEventTime(this._mainRequestDOMContentLoadedTime);
-
- var domContentLoadedDivider = createElement("div");
- domContentLoadedDivider.className = "network-event-divider network-blue-divider";
-
- var domContentLoadedDividerPadding = createElement("div");
- domContentLoadedDividerPadding.className = "network-event-divider-padding";
- domContentLoadedDividerPadding.title = WebInspector.UIString("DOMContentLoaded event");
- domContentLoadedDividerPadding.appendChild(domContentLoadedDivider);
- domContentLoadedDividerPadding.style.left = percent + "%";
- this._timelineGrid.addEventDivider(domContentLoadedDividerPadding);
+ var loadTimePercent = calculator.computePercentageFromEventTime(this._mainRequestLoadTime);
+ if (this._mainRequestLoadTime !== -1 && loadTimePercent >= 0) {
+ var loadDivider = createElementWithClass("div", "network-event-divider-padding");
+ loadDivider.createChild("div", "network-event-divider network-red-divider");
+ loadDivider.title = WebInspector.UIString("Load event");
+ loadDivider.style.left = loadTimePercent + "%";
+ this._timelineGrid.addEventDivider(loadDivider);
+ }
+
+ var domLoadTimePrecent = calculator.computePercentageFromEventTime(this._mainRequestDOMContentLoadedTime);
+ if (this._mainRequestDOMContentLoadedTime !== -1 && domLoadTimePrecent >= 0) {
+ var domContentLoadedDivider = createElementWithClass("div", "network-event-divider-padding");
+ domContentLoadedDivider.createChild("div", "network-event-divider network-blue-divider");
+ domContentLoadedDivider.title = WebInspector.UIString("DOMContentLoaded event");
+ domContentLoadedDivider.style.left = domLoadTimePrecent + "%";
+ this._timelineGrid.addEventDivider(domContentLoadedDivider);
}
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698