Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sync/protocol/article_specifics.proto

Issue 717793007: Add attachments support to DomDistillerStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/dom_distiller/core/dom_distiller_store.cc ('K') | « components/dom_distiller/core/dom_distiller_store_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/protocol/article_specifics.proto
diff --git a/sync/protocol/article_specifics.proto b/sync/protocol/article_specifics.proto
index 00631fd16ece787eb3951c02129e2c37266b05fe..cf1f6ed87996fa56a7b9db9ce6c2e2faec04471e 100644
--- a/sync/protocol/article_specifics.proto
+++ b/sync/protocol/article_specifics.proto
@@ -11,6 +11,8 @@ option retain_unknown_fields = true;
package sync_pb;
+import "attachments.proto";
+
// Properties of Article objects.
message ArticleSpecifics {
// Next ID to use: 4
pavely 2014/11/17 19:09:00 Could you update "Next ID"? Do we even need it?
cjhopman 2014/11/18 20:57:45 Done.
@@ -20,6 +22,8 @@ message ArticleSpecifics {
optional string title = 2;
repeated ArticlePage pages = 3;
+
+ optional ArticleAttachments attachments = 4;
}
message ArticlePage {
@@ -27,3 +31,7 @@ message ArticlePage {
optional string url = 1;
}
+
+message ArticleAttachments {
+ optional AttachmentIdProto distilled_article = 1;
+}
« components/dom_distiller/core/dom_distiller_store.cc ('K') | « components/dom_distiller/core/dom_distiller_store_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698