Issue 717793005: Fix signed integer overflow in GetRefNumUpper24.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 717793005: Fix signed integer overflow in GetRefNumUpper24. (Closed)

Created:
6 years, 1 month ago by rickyz (no longer on Chrome)

Modified:
6 years, 1 month ago

Reviewers:
Tom Sepez

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix signed integer overflow in GetRefNumUpper24. Committed: https://crrev.com/71cbda10ac121e51331f366c2128d8dec4fcc923 Cr-Commit-Position: refs/heads/master@{#303777}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	ipc/ipc_message.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

rickyz (no longer on Chrome)

Hey, I've been looking at ubsan warnings in chrome, and taking a stab at fixing ...

6 years, 1 month ago (2014-11-11 23:13:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717793005/1

6 years, 1 month ago (2014-11-12 00:46:34 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-12 01:34:13 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/71cbda10ac121e51331f366c2128d8dec4fcc923
Cr-Commit-Position: refs/heads/master@{#303777}