Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 717753002: modify nothingToDraw to notice filters (Closed)

Created:
6 years, 1 month ago by reed1
Modified:
6 years, 1 month ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

modify nothingToDraw to notice filters BUG=skia: Committed: https://skia.googlesource.com/skia/+/d5688c509293a450c058e0cc1f4673be2931bb5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M src/core/SkPaint.cpp View 2 chunks +16 lines, -1 line 0 comments Download
M tests/PaintTest.cpp View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
reed1
6 years, 1 month ago (2014-11-11 15:31:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717753002/1
6 years, 1 month ago (2014-11-11 15:32:32 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-11 15:32:32 UTC) #5
djsollen
lgtm
6 years, 1 month ago (2014-11-11 18:59:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d5688c509293a450c058e0cc1f4673be2931bb5c
6 years, 1 month ago (2014-11-11 19:01:03 UTC) #7
mtklein
6 years, 1 month ago (2014-11-11 20:12:27 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/717813002/ by mtklein@google.com.

The reason for reverting is: modecolorfilters, perhaps more changed.

Powered by Google App Engine
This is Rietveld 408576698