Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: pkg/analyzer/test/generated/all_the_rest.dart

Issue 717723003: Issue 21549. Fix for infinite loop in the Angular expression parser (Dart version). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/engine.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/all_the_rest.dart
diff --git a/pkg/analyzer/test/generated/all_the_rest.dart b/pkg/analyzer/test/generated/all_the_rest.dart
index 09632eb8621d3d29ff18ab0b44b848366fb07e43..128ea5d2063ec36fb61814737488a9af69d4935a 100644
--- a/pkg/analyzer/test/generated/all_the_rest.dart
+++ b/pkg/analyzer/test/generated/all_the_rest.dart
@@ -2235,7 +2235,7 @@ class MyController {
assertResolvedIdentifier2("ctrl", "MyController");
}
- void test_resolveExpression_withFilter() {
+ void test_resolveExpression_withFormatter() {
addMyController();
_resolveIndexNoErrors(
AngularTest.createHtmlWithMyController("{{ctrl.field | uppercase}}"));
@@ -2243,7 +2243,14 @@ class MyController {
assertResolvedIdentifier("uppercase");
}
- void test_resolveExpression_withFilter_notSimpleIdentifier() {
+ void test_resolveExpression_withFormatter_missingColon() {
+ addMyController();
+ resolveIndex2(
+ AngularTest.createHtmlWithMyController("{{ctrl.field | uppercase, lowercase}}"));
+ assertErrors(indexSource, [AngularCode.MISSING_FORMATTER_COLON]);
+ }
+
+ void test_resolveExpression_withFormatter_notSimpleIdentifier() {
addMyController();
resolveIndex2(
AngularTest.createHtmlWithMyController("{{ctrl.field | not.supported}}"));
« no previous file with comments | « pkg/analyzer/lib/src/generated/engine.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698