Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp - Issue 717703002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

Issue 717703002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

diff --git a/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp b/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

index 184136eaa2329cd4ea4b93bf35b4a2aa4448af6f..932901eff4c48ba0c2d89e7d2d995e39c18534d0 100644

--- a/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

+++ b/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

@@ -65,7 +65,7 @@ static v8::Local<v8::Object> createInjectedScriptHostV8Wrapper(PassRefPtrWillBeR

{

ASSERT(host);

- v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext, &V8InjectedScriptHost::wrapperTypeInfo, host->toScriptWrappableBase(), isolate);

+ v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(isolate, creationContext, &V8InjectedScriptHost::wrapperTypeInfo, host->toScriptWrappableBase());

if (UNLIKELY(wrapper.IsEmpty()))

return wrapper;

« no previous file with comments | « Source/bindings/core/v8/V8Initializer.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »