Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.cpp

Issue 717703002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptCallStackFactory.cpp ('k') | Source/bindings/core/v8/ScriptWrappable.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptDebugServer.cpp
diff --git a/Source/bindings/core/v8/ScriptDebugServer.cpp b/Source/bindings/core/v8/ScriptDebugServer.cpp
index cc1215f3d8b5eaf6c15cc845ba1c7f4193ce8a3b..0b98bba12ab52637c9891566c5cec5df04216959 100644
--- a/Source/bindings/core/v8/ScriptDebugServer.cpp
+++ b/Source/bindings/core/v8/ScriptDebugServer.cpp
@@ -666,7 +666,7 @@ void ScriptDebugServer::compileScript(ScriptState* scriptState, const String& ex
*exceptionDetailsText = toCoreStringWithUndefinedOrNullCheck(message->Get());
*lineNumber = message->GetLineNumber();
*columnNumber = message->GetStartColumn();
- *stackTrace = createScriptCallStack(message->GetStackTrace(), message->GetStackTrace()->GetFrameCount(), m_isolate);
+ *stackTrace = createScriptCallStack(m_isolate, message->GetStackTrace(), message->GetStackTrace()->GetFrameCount());
}
return;
}
@@ -707,7 +707,7 @@ void ScriptDebugServer::runScript(ScriptState* scriptState, const String& script
*exceptionDetailsText = toCoreStringWithUndefinedOrNullCheck(message->Get());
*lineNumber = message->GetLineNumber();
*columnNumber = message->GetStartColumn();
- *stackTrace = createScriptCallStack(message->GetStackTrace(), message->GetStackTrace()->GetFrameCount(), m_isolate);
+ *stackTrace = createScriptCallStack(m_isolate, message->GetStackTrace(), message->GetStackTrace()->GetFrameCount());
}
} else {
*result = ScriptValue(scriptState, value);
« no previous file with comments | « Source/bindings/core/v8/ScriptCallStackFactory.cpp ('k') | Source/bindings/core/v8/ScriptWrappable.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698