Source/bindings/core/v8/ScriptCallStackFactory.h - Issue 717703002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptCallStackFactory.h

Issue 717703002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/ScriptCallStackFactory.h

diff --git a/Source/bindings/core/v8/ScriptCallStackFactory.h b/Source/bindings/core/v8/ScriptCallStackFactory.h

index 26433d2331cd06ac24780299409a3bf12aa89fe2..bf07839d4d2c8751e2c65bfe500ebcea28ff9915 100644

--- a/Source/bindings/core/v8/ScriptCallStackFactory.h

+++ b/Source/bindings/core/v8/ScriptCallStackFactory.h

@@ -48,7 +48,7 @@ const v8::StackTrace::StackTraceOptions stackTraceOptions = static_cast<v8::Stac

| v8::StackTrace::kScriptNameOrSourceURL

| v8::StackTrace::kFunctionName);

-PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStack(v8::Handle<v8::StackTrace>, size_t maxStackSize, v8::Isolate*);

+PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStack(v8::Isolate*, v8::Handle<v8::StackTrace>, size_t maxStackSize);

PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStack(size_t maxStackSize, bool emptyStackIsAllowed = false);

PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStackForConsole(size_t maxStackSize = ScriptCallStack::maxCallStackSizeToCapture, bool emptyStackIsAllowed = false);

PassRefPtrWillBeRawPtr<ScriptArguments> createScriptArguments(ScriptState*, const v8::FunctionCallbackInfo<v8::Value>& v8arguments, unsigned skipArgumentCount);

« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptCallStackFactory.cpp » ('j') | no next file with comments »