Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 717703002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 5731 matching lines...) Expand 10 before | Expand all | Expand 10 after
5742 5742
5743 const WrapperTypeInfo* wrapperType = wrapperTypeInfo(); 5743 const WrapperTypeInfo* wrapperType = wrapperTypeInfo();
5744 5744
5745 if (frame() && frame()->script().initializeMainWorld()) { 5745 if (frame() && frame()->script().initializeMainWorld()) {
5746 // initializeMainWorld may have created a wrapper for the object, retry from the start. 5746 // initializeMainWorld may have created a wrapper for the object, retry from the start.
5747 v8::Handle<v8::Object> wrapper = DOMDataStore::getWrapper(this, isolate) ; 5747 v8::Handle<v8::Object> wrapper = DOMDataStore::getWrapper(this, isolate) ;
5748 if (!wrapper.IsEmpty()) 5748 if (!wrapper.IsEmpty())
5749 return wrapper; 5749 return wrapper;
5750 } 5750 }
5751 5751
5752 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , wrapperType, toScriptWrappableBase(), isolate); 5752 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(isolate, creati onContext, wrapperType, toScriptWrappableBase());
5753 if (UNLIKELY(wrapper.IsEmpty())) 5753 if (UNLIKELY(wrapper.IsEmpty()))
5754 return wrapper; 5754 return wrapper;
5755 5755
5756 wrapperType->installConditionallyEnabledProperties(wrapper, isolate); 5756 wrapperType->installConditionallyEnabledProperties(wrapper, isolate);
5757 return associateWithWrapper(wrapperType, wrapper, isolate); 5757 return associateWithWrapper(wrapperType, wrapper, isolate);
5758 } 5758 }
5759 5759
5760 v8::Handle<v8::Object> Document::associateWithWrapper(const WrapperTypeInfo* wra pperType, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate) 5760 v8::Handle<v8::Object> Document::associateWithWrapper(const WrapperTypeInfo* wra pperType, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate)
5761 { 5761 {
5762 V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperType, wrapper ); 5762 V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperType, wrapper );
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
5831 #ifndef NDEBUG 5831 #ifndef NDEBUG
5832 using namespace blink; 5832 using namespace blink;
5833 void showLiveDocumentInstances() 5833 void showLiveDocumentInstances()
5834 { 5834 {
5835 WeakDocumentSet& set = liveDocumentSet(); 5835 WeakDocumentSet& set = liveDocumentSet();
5836 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5836 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5837 for (Document* document : set) 5837 for (Document* document : set)
5838 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data()); 5838 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data());
5839 } 5839 }
5840 #endif 5840 #endif
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698