Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 717643003: Extract timing info from distiller result (Closed)

Created:
6 years, 1 month ago by cjhopman
Modified:
6 years, 1 month ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@dd-roll-perf
Project:
chromium
Visibility:
Public.

Description

Extract timing info from distiller result BUG=431067 Committed: https://crrev.com/9457a3edd1983c57a3c3988fa34be7ac4b4caf59 Cr-Commit-Position: refs/heads/master@{#304346}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -1 line) Patch
M components/dom_distiller/core/distiller.cc View 2 chunks +47 lines, -1 line 0 comments Download
M components/dom_distiller/core/distiller_unittest.cc View 1 2 chunks +40 lines, -0 lines 0 comments Download
M components/dom_distiller/core/proto/distilled_page.proto View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
cjhopman
nyquist: *
6 years, 1 month ago (2014-11-12 02:09:07 UTC) #2
nyquist
lgtm, but how about adding a sanity check that these fields are correctly passed through ...
6 years, 1 month ago (2014-11-13 21:43:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717643003/20001
6 years, 1 month ago (2014-11-14 03:18:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/91711) android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/17100)
6 years, 1 month ago (2014-11-14 03:29:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717643003/20001
6 years, 1 month ago (2014-11-15 02:37:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-15 04:03:14 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 04:04:07 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9457a3edd1983c57a3c3988fa34be7ac4b4caf59
Cr-Commit-Position: refs/heads/master@{#304346}

Powered by Google App Engine
This is Rietveld 408576698