Build me2me host debian package as part of Chromoting integration test target.

Build me2me host debian package as part of Chromoting integration test target.

Mainly 2 changes:
Enable building the me2me host when archive_chromoting_tests is set, as it will be on the Chromoting test waterfall.
Actually build the me2me host on the Chromoting test waterfall.

BUG=

Committed: https://crrev.com/2ef1dbaf7d9576684bfe6b2a2dfae00f0d8e0a6a
Cr-Commit-Position: refs/heads/master@{#303956}

[anandc, 2014-11-12 00:15:53]

Patchset #1 (id:1) has been deleted

[anandc, 2014-11-12 00:15:59]

Patchset #1 (id:20001) has been deleted

[anandc, 2014-11-12 00:16:06]

Patchset #1 (id:30001) has been deleted

[anandc, 2014-11-12 00:27:03]

Patchset #1 (id:50001) has been deleted

[anandc, 2014-11-12 01:07:24]

anandc@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[anandc, 2014-11-12 01:07:25]

Lambros,

Could you please take a look? Thanks.

[Lambros, 2014-11-12 02:06:02]

https://codereview.chromium.org/717643002/diff/70001/remoting/remoting_host_l...
File remoting/remoting_host_linux.gypi (right):

https://codereview.chromium.org/717643002/diff/70001/remoting/remoting_host_l...
remoting/remoting_host_linux.gypi:7: ['(OS=="linux" and branding=="Chrome" and
enable_remoting_host==1 and chromeos==0) or (OS=="linux" and
archive_chromoting_tests==1)', {
Optional suggestion:
I think you still want the enable_remoting_host==1 condition, even if
archive_chromoting_tests==1 ?
I guess you really want to change 'branding=="Chrome"' to:
'(branding=="chrome" or archive_chromoting_tests==1)' and leave all the other
conditions enforced?

https://codereview.chromium.org/717643002/diff/70001/testing/chromoting/integ...
File testing/chromoting/integration_tests.gyp (right):

https://codereview.chromium.org/717643002/diff/70001/testing/chromoting/integ...
testing/chromoting/integration_tests.gyp:35:
'../../remoting/remoting.gyp:remoting_me2me_host_archive',
This line is the only thing that is changed, so you can simplify this.

Make the top-level conditional just 'archive_chromoting_tests==1'. Then add
another conditional block inside the target itself, after the 'sources' section.
It can look something like this:

'conditions': [
  ['OS=="linux"', {
    'dependencies': [
      '../../remoting/remoting.gyp:remoting_me2me_host_archive',
    ],
  }],  // OS=="linux"
],

The extra dependency will get added to the existing dependencies, if I'm not
mistaken. There's some special GYP syntax that lets you specify how lists get
merged, but I think this should just work as-is.

[anandc, 2014-11-12 21:50:35]

Thanks Lambros. PTAL.

https://codereview.chromium.org/717643002/diff/70001/remoting/remoting_host_l...
File remoting/remoting_host_linux.gypi (right):

https://codereview.chromium.org/717643002/diff/70001/remoting/remoting_host_l...
remoting/remoting_host_linux.gypi:7: ['(OS=="linux" and branding=="Chrome" and
enable_remoting_host==1 and chromeos==0) or (OS=="linux" and
archive_chromoting_tests==1)', {
On 2014/11/12 02:06:02, Lambros wrote:
> Optional suggestion:
> I think you still want the enable_remoting_host==1 condition, even if
> archive_chromoting_tests==1 ?
> I guess you really want to change 'branding=="Chrome"' to:
> '(branding=="chrome" or archive_chromoting_tests==1)' and leave all the other
> conditions enforced?
> 

Not really. 
We want to build the host if we are creating an archive for Chromoting tests, if
being built on Linux.

https://codereview.chromium.org/717643002/diff/70001/testing/chromoting/integ...
File testing/chromoting/integration_tests.gyp (right):

https://codereview.chromium.org/717643002/diff/70001/testing/chromoting/integ...
testing/chromoting/integration_tests.gyp:35:
'../../remoting/remoting.gyp:remoting_me2me_host_archive',
On 2014/11/12 02:06:02, Lambros wrote:
> This line is the only thing that is changed, so you can simplify this.
> 
> Make the top-level conditional just 'archive_chromoting_tests==1'. Then add
> another conditional block inside the target itself, after the 'sources'
section.
> It can look something like this:
> 
> 'conditions': [
>   ['OS=="linux"', {
>     'dependencies': [
>       '../../remoting/remoting.gyp:remoting_me2me_host_archive',
>     ],
>   }],  // OS=="linux"
> ],
> 
> The extra dependency will get added to the existing dependencies, if I'm not
> mistaken. There's some special GYP syntax that lets you specify how lists get
> merged, but I think this should just work as-is.

Done.

[Lambros, 2014-11-12 23:27:00]

lgtm

https://codereview.chromium.org/717643002/diff/90001/remoting/remoting_host_l...
File remoting/remoting_host_linux.gypi (right):

https://codereview.chromium.org/717643002/diff/90001/remoting/remoting_host_l...
remoting/remoting_host_linux.gypi:7: ['OS=="linux" and ( (branding=="Chrome" and
enable_remoting_host==1 and chromeos==0) or (archive_chromoting_tests==1) )', {
optional: I don't think you need () around archive_chromoting_tests==1

[anandc, 2014-11-12 23:34:18]

https://codereview.chromium.org/717643002/diff/90001/remoting/remoting_host_l...
File remoting/remoting_host_linux.gypi (right):

https://codereview.chromium.org/717643002/diff/90001/remoting/remoting_host_l...
remoting/remoting_host_linux.gypi:7: ['OS=="linux" and ( (branding=="Chrome" and
enable_remoting_host==1 and chromeos==0) or (archive_chromoting_tests==1) )', {
On 2014/11/12 23:27:00, Lambros wrote:
> optional: I don't think you need () around archive_chromoting_tests==1

Acknowledged.
Agreed. I'll keep them for now: it reads more symmetrically this way.
Thanks.

[anandc, 2014-11-12 23:34:25]

The CQ bit was checked by anandc@chromium.org

[commit-bot: I haz the power, 2014-11-12 23:35:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/717643002/90001

[commit-bot: I haz the power, 2014-11-13 01:33:16]

Committed patchset #2 (id:90001)

[commit-bot: I haz the power, 2014-11-13 01:34:33]

Patchset 2 (id:??) landed as
https://crrev.com/2ef1dbaf7d9576684bfe6b2a2dfae00f0d8e0a6a
Cr-Commit-Position: refs/heads/master@{#303956}