Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(72)

Issue 717573004: [Android] Thoroughly reset gesture detection upon page navigation (Closed)

Created:
5 years ago by jdduke (slow)
Modified:
5 years ago
Reviewers:
tdresser, no sievers
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, posciak+watch_chromium.org, tdresser+watch_chromium.org, jam, penghuang+watch_chromium.org, mcasas+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Thoroughly reset gesture detection upon page navigation The current gesture reset logic on Android uses a cancellation event synthesized from the active touch sequence. However, this fails to reset detection for timeout-based events, e.g. delayed tap and double-tap, just after the pointer has just been released. Expose an explicit gesture detection reset hook on the GestureProvider, called when the main frame navigates or the window loses focus. BUG=418402 Committed: https://crrev.com/d47c1e4b6bb7e9b485f6dfede0236ddd5c823878 Cr-Commit-Position: refs/heads/master@{#303749}

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 2

Patch Set 3 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -8 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M ui/events/gesture_detection/filtered_gesture_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/gesture_detection/filtered_gesture_provider.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider_unittest.cc View 1 2 4 chunks +27 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
jdduke (slow)
tdresser@: PTAL. I've been through about 50 version of this patch, and this is just ...
5 years ago (2014-11-11 17:49:53 UTC) #2
tdresser
On 2014/11/11 17:49:53, jdduke wrote: > tdresser@: PTAL. I've been through about 50 version of ...
5 years ago (2014-11-11 19:06:39 UTC) #3
tdresser
https://codereview.chromium.org/717573004/diff/20001/ui/events/gesture_detection/gesture_provider_unittest.cc File ui/events/gesture_detection/gesture_provider_unittest.cc (right): https://codereview.chromium.org/717573004/diff/20001/ui/events/gesture_detection/gesture_provider_unittest.cc#newcode626 ui/events/gesture_detection/gesture_provider_unittest.cc:626: // The long press triggers window focus loss by ...
5 years ago (2014-11-11 19:06:47 UTC) #4
jdduke (slow)
sievers@: Owner review for content/browser/renderer_host/render_widget_host_view_android.cc? Thanks.
5 years ago (2014-11-11 20:34:16 UTC) #6
no sievers
On 2014/11/11 20:34:16, jdduke wrote: > sievers@: Owner review for > content/browser/renderer_host/render_widget_host_view_android.cc? Thanks. lgtm
5 years ago (2014-11-11 21:55:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717573004/20001
5 years ago (2014-11-11 21:57:20 UTC) #9
jdduke (slow)
https://codereview.chromium.org/717573004/diff/20001/ui/events/gesture_detection/gesture_provider_unittest.cc File ui/events/gesture_detection/gesture_provider_unittest.cc (right): https://codereview.chromium.org/717573004/diff/20001/ui/events/gesture_detection/gesture_provider_unittest.cc#newcode626 ui/events/gesture_detection/gesture_provider_unittest.cc:626: // The long press triggers window focus loss by ...
5 years ago (2014-11-11 22:21:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717573004/40001
5 years ago (2014-11-11 22:22:52 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2014-11-11 23:47:27 UTC) #14
commit-bot: I haz the power
5 years ago (2014-11-11 23:48:53 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d47c1e4b6bb7e9b485f6dfede0236ddd5c823878
Cr-Commit-Position: refs/heads/master@{#303749}

Powered by Google App Engine
This is Rietveld 408576698