Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 717573003: DevTools: add ParseAuthorStyleSheet events to Timeline (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
alph, pfeldman, loislo
CC:
blink-reviews, ed+blinkwatch_opera.com, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, blink-reviews-css, darktears, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis
Project:
blink
Visibility:
Public.

Description

DevTools: add ParseAuthorStyleSheet events to Timeline The operation may take noticable time an may give the user additional information about his page performance. BUG=424502 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185190

Patch Set 1 #

Patch Set 2 : Updated test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -0 lines) Patch
A LayoutTests/inspector/tracing/parse-author-style-sheet.html View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/inspector/tracing/parse-author-style-sheet-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/inspector/tracing/resources/style.css View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-enum-stability-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.h View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
yurys
6 years, 1 month ago (2014-11-11 17:23:46 UTC) #2
loislo
lgtm
6 years, 1 month ago (2014-11-11 17:44:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717573003/1
6 years, 1 month ago (2014-11-11 17:45:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/33052)
6 years, 1 month ago (2014-11-11 19:12:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717573003/20001
6 years, 1 month ago (2014-11-12 07:03:27 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 08:09:21 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185190

Powered by Google App Engine
This is Rietveld 408576698