Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/objects-inl.h

Issue 717573002: Fixes for Windows and Mac builds after r25250. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/layout-descriptor-inl.h ('k') | src/string-stream.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 7360 matching lines...) Expand 10 before | Expand all | Expand 10 after
7371 7371
7372 7372
7373 template<typename StaticVisitor> 7373 template<typename StaticVisitor>
7374 void ExternalTwoByteString::ExternalTwoByteStringIterateBody() { 7374 void ExternalTwoByteString::ExternalTwoByteStringIterateBody() {
7375 typedef v8::String::ExternalStringResource Resource; 7375 typedef v8::String::ExternalStringResource Resource;
7376 StaticVisitor::VisitExternalTwoByteString( 7376 StaticVisitor::VisitExternalTwoByteString(
7377 reinterpret_cast<Resource**>(FIELD_ADDR(this, kResourceOffset))); 7377 reinterpret_cast<Resource**>(FIELD_ADDR(this, kResourceOffset)));
7378 } 7378 }
7379 7379
7380 7380
7381 static void IterateBodyUsingLayoutDescriptor(HeapObject* object, 7381 static inline void IterateBodyUsingLayoutDescriptor(HeapObject* object,
7382 int start_offset, int end_offset, 7382 int start_offset,
7383 ObjectVisitor* v) { 7383 int end_offset,
7384 ObjectVisitor* v) {
7384 DCHECK(FLAG_unbox_double_fields); 7385 DCHECK(FLAG_unbox_double_fields);
7385 DCHECK(IsAligned(start_offset, kPointerSize) && 7386 DCHECK(IsAligned(start_offset, kPointerSize) &&
7386 IsAligned(end_offset, kPointerSize)); 7387 IsAligned(end_offset, kPointerSize));
7387 7388
7388 InobjectPropertiesHelper helper(object->map()); 7389 InobjectPropertiesHelper helper(object->map());
7389 DCHECK(!helper.all_fields_tagged()); 7390 DCHECK(!helper.all_fields_tagged());
7390 7391
7391 for (int offset = start_offset; offset < end_offset; offset += kPointerSize) { 7392 for (int offset = start_offset; offset < end_offset; offset += kPointerSize) {
7392 // Visit all tagged fields. 7393 // Visit all tagged fields.
7393 if (helper.IsTagged(offset)) { 7394 if (helper.IsTagged(offset)) {
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
7484 #undef READ_SHORT_FIELD 7485 #undef READ_SHORT_FIELD
7485 #undef WRITE_SHORT_FIELD 7486 #undef WRITE_SHORT_FIELD
7486 #undef READ_BYTE_FIELD 7487 #undef READ_BYTE_FIELD
7487 #undef WRITE_BYTE_FIELD 7488 #undef WRITE_BYTE_FIELD
7488 #undef NOBARRIER_READ_BYTE_FIELD 7489 #undef NOBARRIER_READ_BYTE_FIELD
7489 #undef NOBARRIER_WRITE_BYTE_FIELD 7490 #undef NOBARRIER_WRITE_BYTE_FIELD
7490 7491
7491 } } // namespace v8::internal 7492 } } // namespace v8::internal
7492 7493
7493 #endif // V8_OBJECTS_INL_H_ 7494 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/layout-descriptor-inl.h ('k') | src/string-stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698