Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 717553003: Don't create ServiceWorker provider in dedicated workers (yet) (Closed)

Created:
6 years, 1 month ago by kinuko
Modified:
6 years, 1 month ago
Reviewers:
michaeln, michaeln1, adamk
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Don't create ServiceWorker provider in dedicated workers (yet) We don't expose ServiceWorker in WorkerNavigator yet, and creating a provider for workers could cause data-race with the current code. (See https://code.google.com/p/chromium/issues/detail?id=423107#c8 for more details) BUG=423107, 371690 R=michaeln Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/web/WorkerGlobalScopeProxyProviderImpl.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kinuko
I thought probably I could fix this bug that I introduced half a year ago. ...
6 years, 1 month ago (2014-11-10 16:09:23 UTC) #1
michaeln1
lgtm (thank you kinuko!)
6 years, 1 month ago (2014-11-10 22:35:48 UTC) #3
kinuko
Adam, can you do the OWNER review for this?
6 years, 1 month ago (2014-11-11 00:55:22 UTC) #5
adamk
lgtm for Source/web
6 years, 1 month ago (2014-11-11 00:56:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717553003/1
6 years, 1 month ago (2014-11-11 01:00:23 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 02:02:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185090

Powered by Google App Engine
This is Rietveld 408576698