Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 717493003: Update UseCounter::deprecationMessage() cases to use the replacedBy function (Closed)

Created:
6 years, 1 month ago by kkristof
Modified:
5 years, 11 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update UseCounter::deprecationMessage() cases to use the replacedBy function The updated messages can use the replacedBy() function to generate the message. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188205

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Total comments: 7

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -33 lines) Patch
M LayoutTests/fullscreen/full-screen-iframe-legacy-expected.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing/console-timeline-expected.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-mark-timeline-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing/timeline-timer-fired-from-eval-call-site-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/video-prefixed-fullscreen-expected.txt View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/fast/table/table-hspace-align-center-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug1261-expected.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/table/table-hspace-align-center-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/tables/mozilla/bugs/bug1261-expected.txt View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/table/table-hspace-align-center-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/tables/mozilla/bugs/bug1261-expected.txt View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/table/table-hspace-align-center-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/tables/mozilla/bugs/bug1261-expected.txt View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 3 4 5 6 5 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 26 (7 generated)
kkristof
6 years, 1 month ago (2014-11-10 17:26:56 UTC) #2
Julien - ping for review
We don't put an empty BUG= line in the description. Also your change should have ...
6 years, 1 month ago (2014-11-18 00:24:33 UTC) #3
kkristof
On 2014/11/18 00:24:33, Julien Chaffraix - PST wrote: > We don't put an empty BUG= ...
6 years, 1 month ago (2014-11-18 08:15:34 UTC) #4
kkristof
Hi, I have updated the patch. Please take a look.
6 years ago (2014-12-10 16:21:28 UTC) #6
Julien - ping for review
I don't know enough C++11 to actually review this change. The idea of the change ...
6 years ago (2014-12-12 00:33:29 UTC) #8
Nico
https://codereview.chromium.org/717493003/diff/20001/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/717493003/diff/20001/Source/core/frame/UseCounter.cpp#newcode674 Source/core/frame/UseCounter.cpp:674: for (const char* replacementItem : { replacementItems... }) { ...
6 years ago (2014-12-12 03:57:49 UTC) #9
Julien - ping for review
https://codereview.chromium.org/717493003/diff/20001/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/717493003/diff/20001/Source/core/frame/UseCounter.cpp#newcode671 Source/core/frame/UseCounter.cpp:671: String replacementMessage; Probably better to use a StringBuilder even ...
6 years ago (2014-12-12 17:27:46 UTC) #10
kkristof
Hi, I have updated the patch. I removed the quoting from the replacedBy function so ...
6 years ago (2014-12-16 15:27:30 UTC) #11
Julien - ping for review
+Joshua as the authors of the FIXME and deprecator extraordinaire, in case he has some ...
6 years ago (2014-12-16 16:32:41 UTC) #13
jsbell
On 2014/12/16 16:32:41, Julien Chaffraix - PST wrote: > +Joshua as the authors of the ...
6 years ago (2014-12-16 16:39:38 UTC) #14
kkristof
> Let's keep the quotes. > > The other uses weren't updated just to reduce ...
6 years ago (2014-12-17 14:56:22 UTC) #15
jsbell
I ran another try job, relevant layout test results here: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/39283/layout-test-results/results.html The non-timeouts look as ...
6 years ago (2014-12-17 21:29:19 UTC) #16
jsbell
I'll kick off another try job to see how the changes look, but now that ...
6 years ago (2014-12-18 20:05:50 UTC) #17
kkristof
On 2014/12/18 20:05:50, jsbell wrote: > I'll kick off another try job to see how ...
6 years ago (2014-12-19 15:28:49 UTC) #18
jsbell
Well that's simpler. :) lgtm but please inspect any layout test failures (don't assume they're ...
6 years ago (2014-12-19 23:36:02 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717493003/120001
5 years, 11 months ago (2015-01-09 16:05:57 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/45527)
5 years, 11 months ago (2015-01-09 17:47:05 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717493003/140001
5 years, 11 months ago (2015-01-12 07:45:35 UTC) #25
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 08:57:29 UTC) #26
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188205

Powered by Google App Engine
This is Rietveld 408576698