Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 717473002: [turbofan] Fix select lowering. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix select lowering. Select lowering must not merge Select nodes that depend on each other, because the resulting graph is not schedulable. TEST=unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25236

Patch Set 1 #

Patch Set 2 : Added TODO. REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -15 lines) Patch
M src/compiler/node.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/select-lowering.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/select-lowering.cc View 1 1 chunk +43 lines, -11 lines 0 comments Download
M test/unittests/compiler/select-lowering-unittest.cc View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-10 07:17:45 UTC) #2
Jarin
lgtm (although we need to keep an eye on performance of this)
6 years, 1 month ago (2014-11-10 10:26:56 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-10 10:29:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25236 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698