Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 717453002: Remove unnecessary methods and collapse function calls in the preloader code (Closed)

Created:
6 years, 1 month ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 1 month ago
Reviewers:
Nate Chapin
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unnecessary methods and collapse function calls in the preloader code - Remove PreloadRequest::defer() - Remove ResourceFetcher::requestPreload(). The only user is preload() and is just calling requestPreload(). - Move setDefer() call in HTMLResourcePreloader::preload() into resourceRequest() call - Make HTMLResourcePreloader::preload() private R=japhet BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185100

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M Source/core/fetch/ResourceFetcher.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
tyoshino (SeeGerritForStatus)
6 years, 1 month ago (2014-11-10 05:51:29 UTC) #2
Nate Chapin
Yay cleanup! LGTM
6 years, 1 month ago (2014-11-10 21:40:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717453002/40001
6 years, 1 month ago (2014-11-11 03:42:53 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 04:45:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 185100

Powered by Google App Engine
This is Rietveld 408576698