chrome/browser/ui/views/toolbar/wrench_menu_observer.h - Issue 71743002: [Toolbar Views] Move toolbar files to a new subdirectory.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/toolbar/wrench_menu_observer.h

Issue 71743002: [Toolbar Views] Move toolbar files to a new subdirectory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_VIEWS_WRENCH_MENU_OBSERVER_H_	5 #ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_WRENCH_MENU_OBSERVER_H_

6 #define CHROME_BROWSER_UI_VIEWS_WRENCH_MENU_OBSERVER_H_	6 #define CHROME_BROWSER_UI_VIEWS_TOOLBAR_WRENCH_MENU_OBSERVER_H_

7	7

	8 // TODO(gbillock): Make this an inner class of WrenchMenu. (even needed?)
	tfarina 2013/11/22 22:21:30 why did you add this TODO? Quoting from chromium why did you add this TODO? Quoting from chromium coding style: "Prefer putting delegate classes in their own header files. Implementors of the delegate interface will often be included elsewhere, which will often cause more coupling with the header of the main class." http://www.chromium.org/developers/coding-style - Code formatting section We also discussed about this in https://codereview.chromium.org/79773005/
8 class WrenchMenuObserver {	9 class WrenchMenuObserver {

9 public:	10 public:

10 // Invoked when the WrenchMenu is about to be destroyed (from its destructor).	11 // Invoked when the WrenchMenu is about to be destroyed (from its destructor).

11 virtual void WrenchMenuDestroyed() = 0;	12 virtual void WrenchMenuDestroyed() = 0;

12	13

13 protected:	14 protected:

14 virtual ~WrenchMenuObserver() {}	15 virtual ~WrenchMenuObserver() {}

15 };	16 };

16	17

17 #endif // CHROME_BROWSER_UI_VIEWS_WRENCH_MENU_OBSERVER_H_	18 #endif // CHROME_BROWSER_UI_VIEWS_TOOLBAR_WRENCH_MENU_OBSERVER_H_

OLD	NEW

« no previous file with comments | « chrome/browser/ui/views/toolbar/wrench_menu.cc ('k') | chrome/browser/ui/views/toolbar/wrench_toolbar_button.h » ('j') | no next file with comments »