chrome/browser/chromeos/login/DEPS - Issue 71743002: [Toolbar Views] Move toolbar files to a new subdirectory.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/login/DEPS

Issue 71743002: [Toolbar Views] Move toolbar files to a new subdirectory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # Library used for calculating CRC-32 needed for HWID verification.	2 # Library used for calculating CRC-32 needed for HWID verification.

3 "+third_party/zlib",	3 "+third_party/zlib",

4	4

5 # TODO(tfarina): Remove all these. crbug.com/125846.	5 # TODO(tfarina): Remove all these. crbug.com/125846.

6 # DO NOT ADD ANY MORE ITEMS TO THE LIST BELOW!	6 # DO NOT ADD ANY MORE ITEMS TO THE LIST BELOW!

7 "!chrome/browser/ui/views/location_bar/location_bar_view.h",	7 "!chrome/browser/ui/views/location_bar/location_bar_view.h",

8 "!chrome/browser/ui/views/location_bar/location_icon_view.h",	8 "!chrome/browser/ui/views/location_bar/location_icon_view.h",
	tfarina 2013/11/13 17:27:01 This makes me think, if now we have a toolbar dire This makes me think, if now we have a toolbar directory, isn't location_bar (the omnibox) inside the toolbar? of course, I'm not suggesting moving it in this CL nor in a follow up. I'm just thinking aloud. Greg Billock 2013/11/13 18:23:27 I pondered that, but the location bar is rather co Show quoted text On 2013/11/13 17:27:01, tfarina wrote: > This makes me think, if now we have a toolbar directory, isn't location_bar (the > omnibox) inside the toolbar? of course, I'm not suggesting moving it in this CL > nor in a follow up. I'm just thinking aloud. I pondered that, but the location bar is rather complex, and keeping the current organization mirrors other spots in the code as well. The chrome/browser/ui/views directory is rather full, though, so pulling these out is nice.
9 "!chrome/browser/ui/views/reload_button.h",	9 "!chrome/browser/ui/views/toolbar/reload_button.h",

10 # DO NOT ADD ANY MORE ITEMS TO THE ABOVE LIST!	10 # DO NOT ADD ANY MORE ITEMS TO THE ABOVE LIST!

11 ]	11 ]

12	12

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/chromeos/login/simple_web_view_dialog.cc » ('j') | chrome/browser/ui/views/toolbar/wrench_toolbar_button.h » ('J')