Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 717413002: Use "unsigned" rather than "unsigned long" for C++ code interacting with WebIDL's "unsigned long". (Closed)

Created:
6 years, 1 month ago by eroman
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Use "unsigned" rather than "unsigned long" for C++ code interacting with WebIDL's "unsigned long". (WebIDL's "unsigned long" is a 32-bit type) BUG=267360 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M Source/modules/speech/SpeechGrammarList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechGrammarList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognition.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionResult.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionResultList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResultList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
eroman
6 years, 1 month ago (2014-11-12 23:56:45 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-13 00:46:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717413002/1
6 years, 1 month ago (2014-11-13 01:00:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36203)
6 years, 1 month ago (2014-11-13 03:08:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717413002/1
6 years, 1 month ago (2014-11-13 19:19:26 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 20:08:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185315

Powered by Google App Engine
This is Rietveld 408576698