Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 717363002: Clean up blink_skia_config. (Closed)

Created:
6 years, 1 month ago by bungeman-chromium
Modified:
6 years, 1 month ago
CC:
blink-reviews, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Clean up blink_skia_config. The gyp is no longer needed, and the defines in the gypi are no longer required. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185301

Patch Set 1 #

Patch Set 2 : Remove from OWNERS file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -54 lines) Patch
M public/OWNERS View 1 1 chunk +0 lines, -2 lines 0 comments Download
D public/blink_skia_config.gyp View 1 chunk +0 lines, -50 lines 0 comments Download
M public/blink_skia_config.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
bungeman-chromium
6 years, 1 month ago (2014-11-12 21:19:38 UTC) #2
reed1
lgtm
6 years, 1 month ago (2014-11-12 21:32:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717363002/1
6 years, 1 month ago (2014-11-12 21:38:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/19626)
6 years, 1 month ago (2014-11-12 21:42:17 UTC) #8
reed2
lgtm
6 years, 1 month ago (2014-11-12 21:43:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717363002/1
6 years, 1 month ago (2014-11-12 21:45:00 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/19629)
6 years, 1 month ago (2014-11-12 21:53:50 UTC) #13
bungeman-chromium
Apparently, when deleting a file it is seen by the presubmit bot as a change ...
6 years, 1 month ago (2014-11-12 22:12:51 UTC) #15
Mike West
public/ LGTM.
6 years, 1 month ago (2014-11-13 09:54:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717363002/20001
6 years, 1 month ago (2014-11-13 14:57:26 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 16:17:14 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185301

Powered by Google App Engine
This is Rietveld 408576698