ServiceWorker: Add support for .skipWaiting and controllerchange event(2/3)

content/browser/service_worker/service_worker_provider_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_provider_host.h"
 
 #include "base/stl_util.h"
 #include "content/browser/message_port_message_filter.h"
 #include "content/browser/service_worker/service_worker_context_core.h"
 #include "content/browser/service_worker/service_worker_context_request_handler.h"
@@ skipping 37 matching lines @@
     DecreaseProcessReference(*it);
   }
 }
 
 void ServiceWorkerProviderHost::OnRegistrationFailed(
     ServiceWorkerRegistration* registration) {
   DCHECK_EQ(associated_registration_.get(), registration);
   DisassociateRegistration();
 }
 
+void ServiceWorkerProviderHost::OnSkippedWaiting(
+    ServiceWorkerRegistration* registration) {
+  CHECK_EQ(associated_registration_.get(), registration);

[falken, 2014/11/19 04:19:56]

seems DCHECK_EQ is OK here

[xiang, 2014/11/24 07:04:00]

Done.

+  scoped_refptr<ServiceWorkerVersion> waiting_version =
+      registration->waiting_version();
+  CHECK_EQ(waiting_version->status(), ServiceWorkerVersion::INSTALLED);
+  waiting_version->RegisterStatusChangeCallback(
+      base::Bind(&ServiceWorkerProviderHost::SetControllerVersionAttribute,
+                 AsWeakPtr(), waiting_version));

[falken, 2014/11/19 04:19:56]

It's subtle that OnSkippedWaiting is called just before the skip to ACTIVE, so
it waits for any status change then sets controller. We won't detect an error if
the status change is to REDUNDANT for example.

Can ServiceWorkerRegistration instead call OnSkippepWaiting after setting the
version to ACTIVATING?

[xiang, 2014/11/24 07:04:00]

Yes, you are right, we can move it after ACTIVATING if only support current
registration replacing. Thanks!

+}
+
 void ServiceWorkerProviderHost::SetDocumentUrl(const GURL& url) {
   DCHECK(!url.has_ref());
   document_url_ = url;
 }
 
 void ServiceWorkerProviderHost::SetTopmostFrameUrl(const GURL& url) {
   topmost_frame_url_ = url;
 }
 
 void ServiceWorkerProviderHost::SetControllerVersionAttribute(
@@ skipping 176 matching lines @@
     context_->process_manager()->RemoveProcessReferenceFromPattern(
         pattern, process_id_);
   }
 }
 
 bool ServiceWorkerProviderHost::IsContextAlive() {
   return context_ != NULL;
 }
 
 }  // namespace content