Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 717343002: Replace (unused) FontPlatformData.* with harfbuzz variants. (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium, ojan
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -559 lines) Patch
M sky/engine/platform/BUILD.gn View 2 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/platform/fonts/FontPlatformData.h View 1 chunk +117 lines, -20 lines 0 comments Download
M sky/engine/platform/fonts/FontPlatformData.cpp View 1 chunk +140 lines, -82 lines 0 comments Download
D sky/engine/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.h View 1 chunk +0 lines, -123 lines 0 comments Download
D sky/engine/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.cpp View 1 chunk +0 lines, -178 lines 0 comments Download
D sky/engine/platform/fonts/harfbuzz/HarfBuzzFaceCoreText.cpp View 1 chunk +0 lines, -144 lines 0 comments Download
M sky/engine/platform/fonts/linux/FontPlatformDataLinux.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
6 years, 1 month ago (2014-11-12 20:41:43 UTC) #1
ojan
lgtm
6 years, 1 month ago (2014-11-12 20:47:34 UTC) #3
eseidel
6 years, 1 month ago (2014-11-12 22:22:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5978fb28802325195db4e12dcb6e5b21dde119fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698