Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 717303002: Reland "Move from libstlport to libc++ for Android framework builds" (Closed)

Created:
6 years, 1 month ago by scroggo
Modified:
6 years, 1 month ago
Reviewers:
djsollen, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Reland "Move from libstlport to libc++ for Android framework builds" (patchset #1 id:1 of https://codereview.chromium.org/718793003/) > Original issue's description: > > Move from libstlport to libc++ for Android framework builds > > > > Committed: https://skia.googlesource.com/skia/+/ce259510a738fab05a0d456440104f5aba1c9d72 > > TBR=tomhudson@google.com,djsollen@google.com > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/3c3fe7ce4893204eb8bcf885e8a1d539763bca5d TBR=tomhudson@google.com,djsollen@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/8338a9a855cf5e5127dcb62e48d5036b1ad2f29b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M platform_tools/android/bin/android_gdbserver View 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/bin/android_perf View 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/gyp_gen/makefile_writer.py View 2 chunks +0 lines, -9 lines 0 comments Download
M platform_tools/android/gyp_gen/tool_makefile_writer.py View 1 chunk +0 lines, -2 lines 0 comments Download
M platform_tools/android/tests/expectations/Android.mk View 1 chunk +0 lines, -1 line 0 comments Download
M platform_tools/android/tests/expectations/tool/Android.mk View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scroggo
Created Revert of Revert of Move from libstlport to libc++ for Android framework builds
6 years, 1 month ago (2014-11-12 19:43:41 UTC) #1
djsollen
lgtm
6 years, 1 month ago (2014-11-12 19:50:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/717303002/1
6 years, 1 month ago (2014-11-12 19:52:10 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 19:52:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8338a9a855cf5e5127dcb62e48d5036b1ad2f29b

Powered by Google App Engine
This is Rietveld 408576698